Skip to content

Commit

Permalink
[js-code-coverage] Uprev libraries and add istanbul-lib-coverage
Browse files Browse the repository at this point in the history
Both these packages have gone up a version and provide new tooling
(specifically v8-to-istanbul) that is critical for code coverage
remapping. This also adds the istanbul-lib-coverage package explicitly
as a recent bug (istanbuljs/istanbuljs#322)
causes the reports to return with "Cannot find locations of undefined".
It is fixed when using version 3.0.2.

Bug: 1337530
Test: ./update_npm_deps
Change-Id: I6a10ec492707545e6b3ee90db4598997562eae3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3761783
Commit-Queue: Ben Reich <benreich@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1024532}
NOKEYCHECK=True
GitOrigin-RevId: f434ed5f6727d647dd8a2aa82970a15e6f40b18b
  • Loading branch information
ben-reich authored and Copybara-Service committed Jul 15, 2022
1 parent 741fe59 commit 154cdbc
Show file tree
Hide file tree
Showing 4 changed files with 84 additions and 30 deletions.
15 changes: 13 additions & 2 deletions js_code_coverage/README.chromium
@@ -1,7 +1,7 @@
Name: V8 to Istanbul Coverage Converter
Short Name: v8-to-istanbul
URL: https://www.npmjs.com/package/v8-to-istanbul
Version: 7.1.2
Version: 9.0.1
License: ISC
License File: NOT_SHIPPED
Security Critical: no
Expand All @@ -15,7 +15,7 @@ Local Modifications:
Name: Source map
Short Name: source-map
URL: https://www.npmjs.com/package/source-map
Version: 0.7.3
Version: 0.7.4
License: BSD-3-Clause
License File: NOT_SHIPPED
Security Critical: No. Not shipped in Chrome, used to generate source maps for build steps.
Expand Down Expand Up @@ -56,3 +56,14 @@ Security Critical: No. Not shipped in Chrome, used to take arguments for JS file
Description:
Argparse is used to take, validate and parse CLI arguments for JavaScript scripts
which are run as CLI scripts.

Name: istanbul-lib-coverage
Short Name: istanbul-lib-coverage
URL: https://www.npmjs.com/package/istanbul-lib-coverage
Version: 3.2.0
License: BSD-3-Clause
License File: NOT_SHIPPED
Security Critical: No. Not shipped in Chrome, used to merge coverage reports.

Description:
istanbul-lib-coverage is used to merge coverage reports by the NYC library.
2 changes: 1 addition & 1 deletion js_code_coverage/node_modules.tar.gz.sha1
@@ -1 +1 @@
0871d22e51e0e48b8bc98adce4b3cfade3939f97
d538975c93eefc7bafd599b50f867e90c1ef17f3
92 changes: 67 additions & 25 deletions js_code_coverage/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions js_code_coverage/package.json
Expand Up @@ -4,8 +4,9 @@
"author": "benreich@chromium.org",
"dependencies": {
"argparse": "2.0.1",
"istanbul-lib-coverage": "3.2.0",
"nyc": "15.1.0",
"source-map": "0.7.3",
"v8-to-istanbul": "7.1.2"
"source-map": "0.7.4",
"v8-to-istanbul": "9.0.1"
}
}

0 comments on commit 154cdbc

Please sign in to comment.