This repository has been archived by the owner on May 8, 2020. It is now read-only.
Added changes to support chromium downloading behind an http proxy. #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcworld
reviewed
Aug 11, 2019
| logger.info('Not using a proxy...') | ||
| conn = urllib3.PoolManager() | ||
| else: | ||
| logger.info('Using proxy: %s' % HTTP_PROXY) |
There was a problem hiding this comment.
The else branch will only be executed when HTTP_PROXY is the empty string. I presume you want to invert the condition. Did you test this change?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're stuck behind a proxy, it can be very difficult to make the existing downloader work. These simple changes will allow the system to pick up the very common $http_proxy environmental variable commonly used on Linux to control proxy usage for applications.