fix caesar cipher issues, briefly tested locally on ubuntu and window… #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s 10
Description
Previous caesar cipher obfuscator did not work for unix systems running sh (rather than bash) within sandcat (which seems to be the default), and for both sh and psh executors would only print out the command at the end (rather than actually execute it). It also had some issues with special characters that could cause the command to crash. I have made changes so that the caesar cipher only rotates letters within the original command, as well as escaping out special characters for each executor, so that these issues do not arise.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
I ran a couple operations in CALDERA using my changes to the caesar cipher obfuscator and they worked.
Checklist: