160 psi detector #162
Open
160 psi detector #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSI Drift Detector
There was a problem hiding this comment.
- Unit tests, to hit 100% coverage
- Should fill in
tests/menelaus/data_drift/test_psi_detector.py.tests/menelaus/change_detection/test_adwin.pycan be used as a model.
- Should fill in
- docstrings for each method and the class itself.
- Add a reference in
docs/source/refs.bib, and include that tag in the class docstring
Adding PSI
|
@tms-bananaquit @951378644 FYI this looks good to me after the most recent commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.