Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Threat Column #5128

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Add Threat Column #5128

wants to merge 17 commits into from

Conversation

ejaronne
Copy link
Contributor

@ejaronne ejaronne commented Oct 23, 2023 •
edited by Amndeep7

DO NOT MERGE AS IS - REMOVES THE RUNTIME COLUMN

Add threat column to control rows (initially just replace Run Time with Related Threats)

Before merging:

  • Re-add runtime column
  • Figure out solution for adding/removing desired columns
  • URLs include user provided values so make sure to sanitize those inputs
  • Come up with a better algorithm for sorting

W/r to the control summary

  • Confirm names
  • Remove console logs
  • Flesh out documentation
  • Write saf cli integration
  • Sonarqube doesn't understand when || is correct behavior as opposed to ?? so go and correct the warnings in the branch and then again on merge

@ejaronne ejaronne changed the title Update ControlRowHeader.vue Add Threat Column Oct 23, 2023
@Amndeep7
finished implementing the swap for runtime to threats
6588c6c 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 Amndeep7 added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 24, 2023
@Amndeep7
made a better hover text / description
d647498 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
Merge branch 'master' into threat_column
6bb2348
@Amndeep7
enabled sorting for threats
0fc9803 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
Copy link
Contributor

image
got sorting working for threats - currently 'no threats' are considered 'less than' threats so ascending sort has nothing at the top and descending sort goes from greatest to least threat by alphanumeric order / standard string comparison

@Amndeep7
Merge branch 'master' into threat_column
ae9a564
@Amndeep7
made control summary
244f582 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
made counts track all possible control statuses properly
0fb9fc0 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
linting
5f94064 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7
renaming
75dc8c1 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Awaiting requested review from Amndeep7

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ejaronne @Amndeep7