-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Mark All As Viewed" checkbox in results view #4666
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Rlin232 <rlin@mitre.org>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
this.viewedControlIds = []; | ||
this.allViewed = Trinary.Off; | ||
} else { | ||
this.items.forEach((item) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for of
this.allViewed = Trinary.Off; | ||
} else { | ||
this.items.forEach((item) => { | ||
if (!this.viewedControlIds.includes(item.control.data.id)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if all you need to do is add unique values to the list, then make 'viewedControlIds' a set so that that process is automatically handled by the data structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend tests are failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want the button to show/hide checkmarked results to change. I want a new button that lets me checkmark/de-checkmark all the controls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when PRs are still WIP don't forget to mark them as draft please
No description provided.