Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock to old version of Dart sass #1490

Merged
merged 1 commit into from Jun 16, 2021
Merged

Lock to old version of Dart sass #1490

merged 1 commit into from Jun 16, 2021

Conversation

rbclark
Copy link
Contributor

@rbclark rbclark commented Jun 16, 2021

The dart sass developers have decided that hiding deprecation warnings, even if they are out of our control, should not be allowed: sass/libsass#2822 (comment)

They have recommended locking to a version that does not have the warnings so this PR does just that.

The dart sass developers have decided that hiding deprecation warnings, even if they are out of our control, should not be allowed: sass/libsass#2822 (comment)

They have recommended locking to a version that does not have the warnings so this PR does just that.
@rbclark rbclark added the ready-to-merge Used by mergify to identify if a PR is ready to merge into master. label Jun 16, 2021
@robthew robthew temporarily deployed to mitre-heimda-locksass-cho3knbb June 16, 2021 13:30 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mergify mergify bot merged commit db60efe into master Jun 16, 2021
@mergify mergify bot deleted the lockSass branch June 16, 2021 13:46
Copy link
Contributor

@sesheikholeslam sesheikholeslam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, no more getting spammed with warnings on boot up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Used by mergify to identify if a PR is ready to merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants