Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test harness (Py3.11) #2744

Merged
merged 9 commits into from Apr 26, 2023
Merged

Update test harness (Py3.11) #2744

merged 9 commits into from Apr 26, 2023

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Apr 21, 2023

Description

Update tests:

  • Start testing Python 3.11
  • Update pinned dependency versions
  • Fix failing operation test that writes file to disk

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally with Tox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@clenk
Increase stacklevel of warnings to appease flake8
933bae0 
B028
@clenk
Use our own AsyncMock
c2d4e69 
The one from unittest doesn't exist in Python 3.7.
Also consolidate a second async mock wrapper for code reuse.
@clenk clenk requested a review from a team as a code owner April 21, 2023 16:06
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@clenk clenk merged commit b082589 into master Apr 26, 2023
12 checks passed
@clenk clenk deleted the clenk/update-test-harness branch April 26, 2023 14:42
Aledangelo pushed a commit to secureware-srl/caldera that referenced this pull request Apr 28, 2023
@clenk @Aledangelo
Update test harness (Py3.11) (mitre#2744)
eb50346 
* Test Python 3.11 in test harness

* Update requirements for Python 3.11

* Fix failing operation test
(writing log to disk)

* Increase stacklevel of warnings to appease flake8
B028

* Use our own AsyncMock
The one from unittest doesn't exist in Python 3.7.
Also consolidate a second async mock wrapper for code reuse.

* Update SonarCloud GitHub action version

* Refactor duplicate string to appease sonarcloud

* Update GitHub Actions versions

* Fix warning stacklevel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elegantmoose elegantmoose Awaiting requested review from elegantmoose elegantmoose is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@clenk