Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: Performance degradation on Catalog Page #2531

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asadali145
Copy link
Contributor

Pre-Flight checklist

  • Screenshots and design review for any changes that affect layout or styling
    • Desktop screenshots
    • Mobile width screenshots
  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

Fixes #2530

What's this PR do?

Fixes performance deadlock between the Catalog and the Product details CMS pages.

How should this be manually tested?

[TO BE ADDED]

Any background context you want to provide?

[TO BE ADDED]

Screenshots (if appropriate)

(Optional)

@odlbot odlbot temporarily deployed to xpro-ci-pr-2531 December 19, 2022 14:10 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #2531 (287737f) into master (0969664) will increase coverage by 8.68%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2531      +/-   ##
==========================================
+ Coverage   88.31%   97.00%   +8.68%     
==========================================
  Files         324      150     -174     
  Lines       15259     4772   -10487     
  Branches     1112        0    -1112     
==========================================
- Hits        13476     4629    -8847     
+ Misses       1521      143    -1378     
+ Partials      262        0     -262     
Impacted Files Coverage Δ
cms/models.py
courses/signals.py
compliance/constants.py
affiliate/admin.py
ecommerce/constants.py
users/apps.py
ecommerce/__init__.py
courseware/models.py
courseware/__init__.py
sheets/refund_request_api.py
... and 164 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@asadali145 asadali145 mentioned this pull request Dec 19, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog CMS Page performance degradation
3 participants