Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog CMS Page performance degradation #2530

Open
asadali145 opened this issue Dec 16, 2022 · 4 comments · May be fixed by #2531
Open

Catalog CMS Page performance degradation #2530

asadali145 opened this issue Dec 16, 2022 · 4 comments · May be fixed by #2531
Assignees
@asadali145
Labels
Bug Something isn't working

Comments

@asadali145
Copy link
Contributor

Steps to Reproduce

  • Check out the master branch.
  • Make sure that you have enough data for the Catalog page.
  • Visit the catalog page.
  • Monitor /silk/requests/. N+1 queries are done on the DB.

Expected Behavior

Actual Behavior

  • N+1 queries

Screenshot or Screencast

Screenshot 2022-12-16 at 7 39 21 PM
@asadali145 asadali145 added the Bug Something isn't working label Dec 16, 2022
@asadali145 asadali145 self-assigned this Dec 19, 2022
This was referenced Dec 19, 2022
Draft
Merged
@arslanashraf7
Copy link
Contributor

@asadali145 Should we close this?

@asadali145
Copy link
Contributor Author

We can close and can also work on the identified improvement if we want to. Not sure about the priority.

@arslanashraf7
Copy link
Contributor

Oh, We need to get #2531 merged for that right?

@asadali145
Copy link
Contributor Author

Yeah, The draft PR kind of adds some improvements but Nathan suggested trying another package. Haven't worked on the PR as the issue was resolved and I got busy with other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asadali145 asadali145

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] fix: Performance degradation on Catalog Page mitodl/mitxpro
2 participants
@arslanashraf7 @asadali145