Move Header Bundle back to Original Location

mitodl · May 21, 2019 · 2a20b69 · 2a20b69
1 parent 117423b
commit 2a20b69
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/courses/templates/course_app_base.html b/courses/templates/course_app_base.html
@@ -1 +1,7 @@
 {% extends "base.html" %}
+{% load render_bundle %}
+
+{% block headercontent %}
+  <div id="header"></div>
+  {% render_bundle 'header' %}
+{% endblock %}
diff --git a/mitxpro/templates/base.html b/mitxpro/templates/base.html
@@ -26,8 +26,6 @@
     {% include "partials/gtm_body.html" %}
     {% hijack_notification %}
     {% block headercontent %}
-      <div id="header"></div>
-      {% render_bundle 'header' %}
     {% endblock %}
     {% block content %}
         {% block banner %}

diff --git a/mitxpro/templates/resource_template.html b/mitxpro/templates/resource_template.html
@@ -1,5 +1,10 @@
 {% extends "base.html" %}
-{% load wagtailcore_tags %}
+{% load render_bundle wagtailcore_tags %}
+
+{% block headercontent %}
+<div id="header"></div>
+{% render_bundle 'header' %}
+{% endblock %}
 
 {% block content %}
 

diff --git a/mitxpro/views_test.py b/mitxpro/views_test.py
@@ -37,7 +37,7 @@ def test_webpack_url(mocker, settings, client):
     response = client.get(reverse("login"))
 
     bundles = {bundle[0][1] for bundle in get_bundle.call_args_list}
-    assert bundles == {"header", "root", "style"}
+    assert bundles == {"root", "style"}
     js_settings = json.loads(response.context["js_settings_json"])
     assert js_settings == {
         "gaTrackingID": "fake",