Merge others work #36
Conversation
|
Hmm @edillmann I'll go ahead and merge @apatil's PR directly while taking care of the comments @trisk and I had. Also, unless he doesn't particularly want to and you need the functionality I'd rather @calmh submit the commits himself. |
|
quick update: just ran into a failing test for |
|
(The zfs package is something I used for one thing but currently don't, so I don't have the drive to integrate my changes, whatever they were, at the moment. :) |
|
@calmh thats fair. @edillmann can you rebase on top of master, I've merged w/ tweaks @apatil's PR. |
|
I repushed this PR, tests are OK |
|
@edillmann breaking the API is a no-go. You're going to have to define other functions. I'd suggest something mimicking https://godoc.org/github.com/mistifyio/gozfs#Datasets, but unfortunately a different name :( Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
pjnorton
modified the milestones:
Sprint 39 - The Planets Align,
Sprint 38 - Heaven Can't Wait
I create this pull request to merge work done by apatil and calmh