Do not ignore performance points 2 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flambert
approved these changes
May 14, 2024
SylvainMorel
added a commit
that referenced
this pull request
May 16, 2024
…ate (3rd try) (#21) In androidx@3521ccd, a fallback was added when there is no coverage for 720p 60 FPS. That introduced performance issues on several device models that are now dropping 15-40 frames / sec in Live playback (depending on the model). That's because they used to stay at a lower resolution/framerate, and are now trying to playback 720P 60 FPS, but they struggle to do so. This PR will allow us to disable the fallback on the identified device models. So they will revert to using the lower fps track. Previous attempts #19 and #20 had an issue with lower resolutions. They were handling the formats that we didn't want to be supported correctly, but they were also discarding lower resolutions/frame rates. This one has been tested on a device similar to the ones with the issue, and is confirmed to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19 I added a way to ignore a bug fix recently added by google that is having a negative impact on playback performance on some devices.
I realized just after that since there's lazy evaluation on the result of the added check, for the change to apply the app would have needed to be restarted. It's not a huge deal, since the app is restarted from time to time, and we don't plan on changing the device list that often. But I still found that annoying.
This PR improves on #19 by making sure we can change the value of the added boolean, and it will have an impact on the next codec change, not the next application execution. To do so, we keep the lazy eval system as it is, but we override the result higher in the stack.