update rename wiki script with "good version" #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Universal-Omega
requested changes
Mar 31, 2024
|
Universal-Omega
force-pushed
the
Reception123-patch-2
branch
from
bff89d0
to
7dad190
Compare
- removed c5 - improved logging - stopped hardcoding reception's homedir - catch an error --------- Co-authored-by: Reception123 <utilizator.receptie123@gmail.com>
Universal-Omega
requested changes
Apr 17, 2024
| @@ -9,6 +12,7 @@ class DbClusterMap(TypedDict): | |||
| c2: str | |||
| c3: str | |||
| c4: str | |||
| c5: str | |||
There was a problem hiding this comment.
Still no c5 CC @RhinosF1
| @@ -21,10 +25,10 @@ class DbClusterMap(TypedDict): | |||
|
|
|||
|
|
|||
| def generate_salt_command(cluster: str, command: str) -> str: | |||
| return f'salt-ssh -E "{cluster}*" cmd.run "{command}"' | |||
| return f'salt-ssh -E "{cluster}" cmd.run "{command}"' | |||
There was a problem hiding this comment.
IIRC we don't need -E if we aren't using * but isn't * required if the full hostname is IE db151.wikitide.net? I can't remember if salt uses that or just db151 though
|
|
||
| # Step 3: Execute MediaWiki rename script | ||
| execute_salt_command(salt_command=generate_salt_command('mwtask181', f'sudo -u www-data php /srv/mediawiki/1.41/extensions/CreateWiki/maintenance/renameWiki.php --wiki=loginwiki --rename {oldwiki_db} {newwiki_db} $user')) | ||
| execute_salt_command(salt_command=generate_salt_command('mwtask181', f'mwscript extensions/CreateWiki/renameWiki.php loginwiki --no-log --rename {oldwiki_db} {newwiki_db} {os.getlogin()}')) |
There was a problem hiding this comment.
I think mwtask181 should be some sort of constant so it is easy to change if task server is changed.
There was a problem hiding this comment.
Yeah that makes sense, how exactly would I do that here?
There was a problem hiding this comment.
Similar to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.