Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miraheze-helpcenter message and add miraheze-faq message #156

Merged
merged 3 commits into from Nov 28, 2020
Merged

Conversation

dmehus
Copy link
Contributor

@dmehus dmehus commented Nov 28, 2020

This GitHub PR accomplishes two things: (1) it revises the Miraheze Help Centre displayed sidebar text back to the U.S. English Miraheze Help Center per discussion with @Reception123 on Discord and (2) it adds a miraheze-faq interface message, per this Meta:Administrators' noticeboard request (https://meta.miraheze.org/w/index.php?title=Meta:Administrators'_noticeboard&diff=147171&oldid=147169&diffmode=source), so that it can be translated on translatewiki.net. Thanks

This GitHub PR accomplishes two things:  (1) it revises the Miraheze Help Centre displayed sidebar text back to the U.S. English Miraheze Help Center per discussion with @Reception123 on Discord and (2) it adds a `miraheze-faq` interface message, per this `Meta:Administrators' noticeboard` request (https://meta.miraheze.org/w/index.php?title=Meta:Administrators'_noticeboard&diff=147171&oldid=147169&diffmode=source), so that it can be translated on translatewiki.net. Thanks
Copy link
Sponsor Member

@Universal-Omega Universal-Omega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added to

"centralauth-groupname": "Miraheze",

@dmehus
Copy link
Contributor Author

dmehus commented Nov 28, 2020

@Universal-Omega I'm confused by what you're saying. Is this not the file that controls where //new// interface messages are added? I can modify this to just change the Miraheze Help Center message, then add the new message to that other file in a separate PR? Sorry, I'm not familiar with the process by which to add multiple commits to a single PR when using the GitHub web-based interface.

@Universal-Omega
Copy link
Sponsor Member

@Universal-Omega I'm confused by what you're saying. Is this not the file that controls where //new// interface messages are added? I can modify this to just change the Miraheze Help Center message, then add the new message to that other file in a separate PR? Sorry, I'm not familiar with the process by which to add multiple commits to a single PR when using the GitHub web-based interface.

Qqq.json is the description of the message to use on translate wiki.net

@dmehus
Copy link
Contributor Author

dmehus commented Nov 28, 2020

@Universal-Omega I'm confused by what you're saying. Is this not the file that controls where //new// interface messages are added? I can modify this to just change the Miraheze Help Center message, then add the new message to that other file in a separate PR? Sorry, I'm not familiar with the process by which to add multiple commits to a single PR when using the GitHub web-based interface.

Qqq.json is the description of the message to use on translate wiki.net

@Universal-Omega Can you clarify this just a bit in less technical terminology, please? Is the qqq.json essentially the source json file that defines the MirahezeMagic custom message names, and then the English file defines the actual messages?

Assuming that's the case, can you confirm that I need to add miraheze-faq to qqq.json in a separate PR (would prefer to do a separate PR as I'm not that great with synchronizing PRs and adding commits for different files; separate PRs shouldn't be a big deal in this instance), and then you will approve both PRs?

@Universal-Omega
Copy link
Sponsor Member

@Universal-Omega I'm confused by what you're saying. Is this not the file that controls where //new// interface messages are added? I can modify this to just change the Miraheze Help Center message, then add the new message to that other file in a separate PR? Sorry, I'm not familiar with the process by which to add multiple commits to a single PR when using the GitHub web-based interface.

Qqq.json is the description of the message to use on translate wiki.net

@Universal-Omega Can you clarify this just a bit in less technical terminology, please? Is the qqq.json essentially the source json file that defines the MirahezeMagic custom message names, and then the English file defines the actual messages?

Assuming that's the case, can you confirm that I need to add miraheze-faq to qqq.json in a separate PR (would prefer to do a separate PR as I'm not that great with synchronizing PRs and adding commits for different files; separate PRs shouldn't be a big deal in this instance), and then you will approve both PRs?

If you want, I can add it myself?

@dmehus
Copy link
Contributor Author

dmehus commented Nov 28, 2020

@Universal-Omega I'm confused by what you're saying. Is this not the file that controls where //new// interface messages are added? I can modify this to just change the Miraheze Help Center message, then add the new message to that other file in a separate PR? Sorry, I'm not familiar with the process by which to add multiple commits to a single PR when using the GitHub web-based interface.

Qqq.json is the description of the message to use on translate wiki.net

@Universal-Omega Can you clarify this just a bit in less technical terminology, please? Is the qqq.json essentially the source json file that defines the MirahezeMagic custom message names, and then the English file defines the actual messages?
Assuming that's the case, can you confirm that I need to add miraheze-faq to qqq.json in a separate PR (would prefer to do a separate PR as I'm not that great with synchronizing PRs and adding commits for different files; separate PRs shouldn't be a big deal in this instance), and then you will approve both PRs?

If you want, I can add it myself?

@Universal-Omega I'd like to do it myself, to be honest, and I could use some additional merged commits, so if you can just confirm that my understanding is correct, I can submit a separate PR.

@Universal-Omega
Copy link
Sponsor Member

@Universal-Omega I'd like to do it myself, to be honest, and I could use some additional merged commits, so if you can just confirm that my understanding is correct, I can submit a separate PR.

No, that is not correct, qqq.json is really confusing, and was hard for me to understand at first, I am not quite sure how to explain it. It is basically the messages to explain the messages. Descriptions of messages I guess.

@Universal-Omega Universal-Omega merged commit cdb6f5b into miraheze:master Nov 28, 2020
@dmehus
Copy link
Contributor Author

dmehus commented Nov 28, 2020

@Universal-Omega I'd like to do it myself, to be honest, and I could use some additional merged commits, so if you can just confirm that my understanding is correct, I can submit a separate PR.

No, that is not correct, qqq.json is really confusing, and was hard for me to understand at first, I am not quite sure how to explain it. It is basically the messages to explain the messages. Descriptions of messages I guess.

@Universal-Omega Well that's reassuring that it qqq.json was confusing to you at first then. Thanks for your clarification, and for walking me through it. I'll maybe ask Reception123 to see if he can explain qqq.json a bit more then so I can fully understand it.

@dmehus dmehus deleted the patch-1 branch November 28, 2020 05:47
@Universal-Omega
Copy link
Sponsor Member

@Universal-Omega I'd like to do it myself, to be honest, and I could use some additional merged commits, so if you can just confirm that my understanding is correct, I can submit a separate PR.

No, that is not correct, qqq.json is really confusing, and was hard for me to understand at first, I am not quite sure how to explain it. It is basically the messages to explain the messages. Descriptions of messages I guess.

@Universal-Omega Well that's reassuring that it qqq.json was confusing to you at first then. Thanks for your clarification, and for walking me through it. I'll maybe ask Reception123 to see if he can explain qqq.json a bit more then so I can fully understand it.

Sounds good, for this message just adding FAQ again works out since it's simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants