Allow calculation of well-separated dimers #84
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an atom is isolated, there are no edges, and the array dimensions can be 0. This causes ambiguity problems when trying to use -1 as an argument to reshape. The proposed modifications catch a few cases where the 0-sized dimensions prevent calculation of well-separated dimers. For more info, see #82 In the context of that discussion, these changes let the following command work, whereas the original version did not: plot_dimers.py --r-min=5.1 --r-max=5.2 --n-samples 2 si-deployed.pth
To calculate the energy of isolated atoms (as opposed to well-separated dimers), one needs to make modifications to nequip. Those modifications can be found here: mir-group/nequip#426
This pull request is merge into the develop branch, whereas the closed request #83 was a merge into main.