Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow calculation of well-separated dimers #84

Closed

Conversation

tjgiese
Copy link

@tjgiese tjgiese commented May 3, 2024

When an atom is isolated, there are no edges, and the array dimensions can be 0. This causes ambiguity problems when trying to use -1 as an argument to reshape. The proposed modifications catch a few cases where the 0-sized dimensions prevent calculation of well-separated dimers. For more info, see #82 In the context of that discussion, these changes let the following command work, whereas the original version did not: plot_dimers.py --r-min=5.1 --r-max=5.2 --n-samples 2 si-deployed.pth

To calculate the energy of isolated atoms (as opposed to well-separated dimers), one needs to make modifications to nequip. Those modifications can be found here: mir-group/nequip#426

This pull request is merge into the develop branch, whereas the closed request #83 was a merge into main.

@tjgiese tjgiese closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant