Add stub test for public module method that was private #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a really strange good find... glad it got fixed in ruby. I'll see about guarding this in a way that passes on the guilty versions and notifies once there's a 3.1 that works. |
zenspider
force-pushed
the
test_public_stub_that_was_private
branch
from
10ff7ea
to
0a65d0b
Compare
|
Just rebased to force a retest... still brokey... on 3.1 but not head... Odd because you can see that bug getting fixed 7 months ago and I could have sworn there's been a patch release since then? |
|
https://www.ruby-lang.org/en/news/2022/04/12/ruby-3-1-2-released/ It looks like 3.1.2 was released after this was fixed in ruby/ruby#5592. CI is using 3.1.2, so I guess it wasn't included. Looks like it will be in 3.1.3: ruby/ruby@9d11ddc |
|
Better go dig up a CVE worthy bug so they have a forcing function to do another release. 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to stub a method that was previously private and explicitly made public. For some reason, this fails on Ruby 3.1.0 (the method reverts to being private). This is a regression in CRuby somewhere, probably related to method aliasing. Still, I believe the test is worth adding to prevent future regressions.
I've opened https://bugs.ruby-lang.org/issues/18600 as well to address the regression in Ruby.