Don't pass implicit blocks for method_missing stubs #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from `send :define_method` to `class_eval` for stubbed methods that would otherwise by handled by `method_missing` With the previous implementation, the block passed to `stub` is in scope during `define_method`, which means that once a method on an object has been stubbed, subsequent method calls will always receive that implicit block. I've added a new test that presents this behavior with the existing implementation, and works properly with this change.
|
Why does this matter? |
|
It matters because the existing implementation can cause behavior changes to the original class. This change attempts to improve stub cleanup to be more comprehensive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
send :define_methodtoclass_evalfor stubbed methodsthat would otherwise by handled by
method_missingWith the previous implementation, the block passed to
stubis inscope during
define_method, which means that once a method on anobject has been stubbed, subsequent method calls will always receive
that implicit block.
I've added a new test that presents this behavior with the existing
implementation, and works properly with this change.