Fix warning from Forwardable for Mock #785
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.4 warns when delegating to a private method with
Forwardable
: https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/56210.When delegating to a Minitest::Mock object with
Forwardable
, a "forwarding to private method" warning is shown.For example, given:
The test will output:
Ideally these warnings would not be shown, because in most cases the expectation is set on a public method.
There explained why:
So, if we implement
respond_to_missing?
as recommended, warning disappered.