Add line number in methods defined by "it" #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the line number of the method defined by "it" blocks in minitest/spec. Our tests at work are "spec" style (they use the DSL to define tests), and we add a line number to the method name that gets defined. The reason I like this is because I can write a test, then run that single test without trying to guess how the test framework defines the method, I just do: ``` $ ruby test_file.rb -n /L56/ ``` This also makes running the single test from Vim quite easy because the editor can just grab the line number and pass it as a parameter to the test runner. This patch only adds the line number if the Ruby version being used supports `source_location` on the `Proc` object, so this should work on all versions of Ruby.
tenderlove
force-pushed
the
line-number-in-spec-tests
branch
from
5f29fa1
to
6bb126a
Compare
|
Have you considered using m? Not a fan of using an executable other than |
|
@zamith I am quite happy with my existing dev setup, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the line number of the method defined by "it" blocks in
minitest/spec. Our tests at work are "spec" style (they use the DSL to
define tests), and we add a line number to the method name that gets
defined. The reason I like this is because I can write a test, then run
that single test without trying to guess how the test framework defines
the method, I just do:
This also makes running the single test from Vim quite easy because the
editor can just grab the line number and pass it as a parameter to the
test runner.
This patch only adds the line number if the Ruby version being used
supports
source_locationon theProcobject, so this should work onall versions of Ruby.