Fix for ARM processors #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
approved these changes
Oct 11, 2022
docker-compose.yml
Outdated
Comment on lines
98
to
95
| test: ["CMD", "wget", "-nv", "-t1", "--spider", "http://localhost:8080/api/health"] | ||
| test: | ||
| [ | ||
| "CMD", | ||
| "wget", | ||
| "-nv", | ||
| "-t1", | ||
| "--spider", | ||
| "http://localhost:8080/api/health", | ||
| ] |
There was a problem hiding this comment.
Do we even need this test now?
There was a problem hiding this comment.
Doesn't seem like it, it's gone
|
It might also be worth changing the port in https://github.com/ministryofjustice/hmpps-approved-premises-tools/blob/main/bin/start-server#L36 from |
Tilt doesn’t support dependencies so we have to remove them and manually wait until the community-api is up tilt-dev/tilt#2210 (comment)
richpjames
force-pushed
the
fix-for-arm-processors
branch
from
cf46bc0
to
0accfa4
Compare
As community-api is the slowest service it make sense for us to wait for it to be up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tilt was not working on my MBP - probably due to the emulation load the community-api was putting on the machine.
Thanks to the work of @pezholio here a multiplatform version of the community-api was created.
However the
ap-tools server startscript was still failing due to the dependencies between the services as mentioned in this issue comment. With these removed and with some patience whilst waiting for the community-api to come up, the issue is resolved.