Skip to content

ministryofjustice/book-a-prison-visit-staff-ui

Repository files navigation

book-a-prison-visit-staff-ui

repo standards badge CircleCI

Staff UI for new Manage a Prison Visit project.

Running the app

The easiest way to run the app is to use docker compose to create the service and all dependencies.

docker-compose pull

docker-compose up

Dependencies

The app requires:

  • hmpps-auth - for authentication
  • redis - session store and token caching

Running the app for development

To start the main services excluding the app itself:

docker-compose up --scale=app=0

Or, to start just Redis if using HMPPS Auth dev:

docker-compose up redis-bapv

Install dependencies using npm install, ensuring you are using >= Node v18.x

Using credentials from the dev namespace, create a .env local settings file

REDIS_HOST=localhost
HMPPS_AUTH_URL=https://sign-in-dev.hmpps.service.justice.gov.uk/auth
HMPPS_AUTH_EXTERNAL_URL=https://sign-in-dev.hmpps.service.justice.gov.uk/auth
NOMIS_AUTH_URL=https://sign-in-dev.hmpps.service.justice.gov.uk/auth
MANAGE_USERS_API_URL=https://manage-users-api-dev.hmpps.service.justice.gov.uk
NODE_ENV=development

# Use credentials from the dev namespace for API and SYSTEM client
API_CLIENT_ID=clientid
API_CLIENT_SECRET=clientsecret
SYSTEM_CLIENT_ID=clientid
SYSTEM_CLIENT_SECRET=clientsecret

COMPONENT_API_URL="https://frontend-components-dev.hmpps.service.justice.gov.uk"
NOMIS_USER_ROLES_API_URL="https://nomis-user-roles-api-dev.prison.service.justice.gov.uk"
ORCHESTRATION_API_URL="https://hmpps-manage-prison-visits-orchestration-dev.prison.service.justice.gov.uk"
PRISONER_SEARCH_API_URL="https://prisoner-search-dev.prison.service.justice.gov.uk"
PRISON_API_URL="https://prison-api-dev.prison.service.justice.gov.uk"
PRISONER_CONTACT_REGISTRY_API_URL="https://prisoner-contact-registry-dev.prison.service.justice.gov.uk"
WHEREABOUTS_API_URL="https://whereabouts-api-dev.service.justice.gov.uk"
PRISON_REGISTER_API_URL="https://prison-register-dev.hmpps.service.justice.gov.uk"

And then, to build the assets and start the app with nodemon:

npm run start:dev

Run linter

npm run lint

Run tests

npm run test

Running integration tests

For local running, start a test db, redis, and wiremock instance by:

docker-compose -f docker-compose-test.yml up

Then run the server in test mode by:

npm run start-feature (or npm run start-feature:dev to run with nodemon)

And then either, run tests in headless mode with:

npm run int-test

Or run tests with the cypress UI:

npm run int-test-ui

Dependency Checks

The template project has implemented some scheduled checks to ensure that key dependencies are kept up to date. If these are not desired in the cloned project, remove references to check_outdated job from .circleci/config.yml

Test Coverage Reports

We use jest code coverage to report on test coverage and produce reports for the unit tests.

Where are the code coverage reports?

In the CircleCI builds find a unit_test job and click on the ARTIFACTS tab.

The unit test coverage report can be found at test_results/jest/coverage/lcov-report/index.html.

Visit journeys – book and update

The same booking journey is used both for initially booking a visit and updating an existing visit. The difference between the two and the different API calls required occurs when submitting the 'Select date and time of visit' page (see POST handler in dateAndTime.ts).

Booking a new visit

  • first time selecting date/time
    • uses POST /visits/application/slot/reserve to create a visit application and gets an application reference
  • changing date/time (before booking)
    • uses PUT /visits/application/{reference}/slot/change to modify the current application

Updating and existing visit

  • first time selecting date/time (which will have been pre-populated with the existing slot if possible)
    • uses PUT /visits/application/{bookingReference}/change to create a new visit application from the existing visit. This gives a new application Reference
  • changing date/time (before booking)
    • also uses PUT /visits/application/{reference}/slot/change to modify the current application

In both cases, at the end of the journey there are two further calls to confirm the booking:

  1. PUT /visits/application/{reference}/slot/change to update/set all the data in the current application
  2. PUT /visits/{applicationReference}/book to complete the application and receive a Visit with status BOOKED

Imported types

Some TypeScript types are imported via the Open API (Swagger) docs, e.g. from the Visits Orchestration Service, Prisoner Contact Registry, Prison API, etc.

These are stored in ./server/@types/, for example ./server/@types/orchestration-api.d.ts. There are also some corresponding files such as ./server/data/orchestrationApiTypes.ts that contain the particular imported types that are actually used in the project.

For example, to update types for the Orchestration service, use the API docs URL from Swagger and the appropriate output filename:

npx openapi-typescript https://hmpps-manage-prison-visits-orchestration-dev.prison.service.justice.gov.uk/v3/api-docs --output ./server/@types/orchestration-api.d.ts

The downloaded file will need tidying (e.g. single rather than double quotes, etc):

  • npm run lint-fix should tidy most of the formatting
  • there may be some remaining errors about empty interfaces; these can be fixed be either removing the line or putting // eslint-disable-next-line @typescript-eslint/no-empty-interface before.

After updating the types, running the TypeScript complier across the project (npx tsc) will show any issues that have been caused by the change.

Import all types

To download and update all the API types and tidy up the files, run:

./bin/update-types.sh

Maintenance page

See the maintenance page README for how to turn this on/off and update the content.

User audit

To record an audit trail of user actions, events are sent to the hmpps-audit-api service SQS queue. Currently, the following are audited (see auditService.ts and auditService.test.ts for details of what is logged):

  • BOOKED_VISIT
  • CANCELLED_VISIT
  • OVERRODE_ZERO_VO
  • PRINTED_VISIT_LIST (unused - feature not yet implemented)
  • RESERVED_VISIT
  • SEARCHED_PRISONERS
  • SEARCHED_VISITS
  • VIEWED_PRISONER
  • VIEWED_VISIT_DETAILS
  • VIEWED_VISITS
  • VISIT_RESTRICTION_SELECTED

Diagnosing audit problems

At present there isn't a simple way to retrieve specific data from the audit service. However, using Application Insights logs, it is possible to see whether messages are either being successfully ingested or instead ending up on the audit service's DLQ (dead-letter queue). For example:

  • To see SQS massages being sent from this application:
traces
| where cloud_RoleName == "book-a-prison-visit-staff-ui"
| where message has "SQS message sent"

The operation_Id from these can be looked up in Application Insights' 'Transaction search' to bring up related information.

  • To see messages being successfully accepted by the audit service:
customEvents
| where cloud_RoleName == "hmpps-audit-api"
| where customDimensions.service == "book-a-prison-visit-staff-ui" 
  • To see failures - e.g. messages that will end up on DLQ:
exceptions
| where cloud_RoleName == "hmpps-audit-api"
| where method has "book-a-prison-visit-staff-ui"