Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary safe headers under CORS #5750

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Apr 2, 2018

Description

Add necessary safe headers under CORS

Motivation and Context

Fixes #5748

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #5750 into master will increase coverage by 1.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5750      +/-   ##
==========================================
+ Coverage   59.11%   60.56%   +1.44%     
==========================================
  Files         193      196       +3     
  Lines       23035    29125    +6090     
==========================================
+ Hits        13618    17639    +4021     
- Misses       7905     9983    +2078     
+ Partials     1512     1503       -9
Impacted Files Coverage Δ
cmd/generic-handlers.go 77.39% <100%> (-2.24%) ⬇️
cmd/gateway-main.go 18.12% <0%> (-7.41%) ⬇️
cmd/storage-rpc-server.go 75.93% <0%> (-6.92%) ⬇️
cmd/admin-rpc-server.go 35.55% <0%> (-6.34%) ⬇️
cmd/storage-rpc-client.go 78.43% <0%> (-6.23%) ⬇️
cmd/service.go 21.42% <0%> (-5.85%) ⬇️
cmd/server-rlimit.go 54.16% <0%> (-5.84%) ⬇️
cmd/lock-rpc-server.go 47.02% <0%> (-5.68%) ⬇️
cmd/disk-cache-config.go 62.5% <0%> (-5.5%) ⬇️
cmd/format-fs.go 52.7% <0%> (-5.25%) ⬇️
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87cc3d...e939ebe. Read the comment docs.

@balamurugana
Copy link
Member

Mint Automation

Test Result
mint-xl.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit b052bfa into minio:master Apr 3, 2018
@harshavardhana harshavardhana deleted the fix-cors branch April 3, 2018 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS: Add Headers required for Range Requests
4 participants