Add logger webhook metrics in metrics-v3 #19515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjalshireesh
changed the title
anjalshireesh
changed the title
anjalshireesh
force-pushed
the
metrics-v3-cluster-webhook
branch
from
b6712fe
to
5a0c6fd
Compare
anjalshireesh
requested review from
donatello,
vadmeste,
harshavardhana and
kannappanr
anjalshireesh
force-pushed
the
metrics-v3-cluster-webhook
branch
2 times, most recently
from
f2f1243
to
00578b4
Compare
harshavardhana
approved these changes
Apr 25, 2024
anjalshireesh
force-pushed
the
metrics-v3-cluster-webhook
branch
from
aaf7f2b
to
ba1ded3
Compare
anjalshireesh
force-pushed
the
metrics-v3-cluster-webhook
branch
from
e98dd1f
to
7f4bc60
Compare
anjalshireesh
changed the title
|
@harshavardhana @shtripat based on latest discussions the endpoint is now changed to |
shtripat
approved these changes
May 7, 2024
anjalshireesh
force-pushed
the
metrics-v3-cluster-webhook
branch
2 times, most recently
from
2320ba9
to
b879a82
Compare
endpoint: /minio/metrics/v3/cluster/webhook metrics: - failed_messages (counter) - online (gauge) - queue_length (gauge) - total_messages (counter)
anjalshireesh
force-pushed
the
metrics-v3-cluster-webhook
branch
from
b879a82
to
7d3514f
Compare
harshavardhana
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
endpoint: /minio/metrics/v3/logger/webhook
metrics:
Motivation and Context
https://github.com/miniohq/engineering/issues/1510
How to test this PR?
curl "http(s)://<host:port>/minio/metrics/v3/logger/webhook"should return the new cluster webhook related metrics
Types of changes
Checklist:
commit-idorPR #here)