Add injection of custom executor service to S3Base supplyAsync calls #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2900,7 +2909,8 @@ protected CompletableFuture<ObjectWriteResponse> putObjectAsync( | |||
| } catch (NoSuchAlgorithmException | IOException e) { | |||
| throw new CompletionException(e); | |||
| } | |||
| }) | |||
| }, | |||
| executorService) | |||
There was a problem hiding this comment.
Any reason why executorService is used selective places?
There was a problem hiding this comment.
I added it to all locations where I saw calls to supplyAsync, runAsync or any other places that I saw which would normally pick the ForkJoinPool.commonPool().
Did you spot any places that I missed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we need to provide our own thread pool for the
CompletableFuture.supplyAsyncto run on, currently that's not possible and it's preventing us from keeping up with library upgrades.