New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ios pwa meta #2548
add ios pwa meta #2548
Conversation
<meta name="mobile-web-app-capable" content="yes"> | ||
<meta name="apple-mobile-web-app-title" content="Miniflux"> | ||
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have the same issue mentioned in PR #1667?
See screenshots in this comment: #1667 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,7 +6,7 @@ | |||
<title>{{template "title" .}} - Miniflux</title> | |||
|
|||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any difference when testing. Can you point me to the viewport-fit=cover
documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.mozilla.org/en-US/docs/Web/CSS/env#usage
This change does not affect the current official theme, but third-party themes can use it to adapt to the iOS safe-area,like this
add meta to support ios pwa status bar color and css env()
Do you follow the guidelines?