Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatars; outline; yarn scripts #8

Merged
merged 3 commits into from Jun 2, 2020
Merged

avatars; outline; yarn scripts #8

merged 3 commits into from Jun 2, 2020

Conversation

awdyson
Copy link
Contributor

@awdyson awdyson commented Jun 2, 2020

Spec: https://www.figma.com/file/PuJi9spJen8q1MELcpFtIo/Forum-Design-System?node-id=1506%3A8782

New styles:
image

New scripts:
yarn build runs a build once.
yarn start watches the src directory for changes and builds.
Note: sass/node-sass#1369 馃檮

@awdyson awdyson requested a review from chinaowl June 2, 2020 16:29
@awdyson
Copy link
Contributor Author

awdyson commented Jun 2, 2020

This doesn't contain the work for the square avatar as we only use that in one location. Open to adding it here, but it didn't seem like the right call at the time

Copy link
Member

@chinaowl chinaowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I agree with not adding the square avatar here.

package.json Show resolved Hide resolved
index.html Show resolved Hide resolved
src/avatars.scss Outdated Show resolved Hide resolved
src/outline.scss Outdated Show resolved Hide resolved
@awdyson awdyson requested a review from chinaowl June 2, 2020 19:09
@awdyson awdyson merged commit 918f9e4 into master Jun 2, 2020
@awdyson awdyson deleted the awd/avatars branch June 2, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants