Skip to content

Commit

Permalink
Merge pull request #73 from mineiros-io/soerenmartius/vulnerability_a…
Browse files Browse the repository at this point in the history
…lerts

Fix default value of vulnerability_alerts
  • Loading branch information
soerenmartius committed Aug 10, 2021
2 parents 64e074e + 559b9bd commit 0889e6c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
13 changes: 11 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.10.1]

### Fixed

- Set `vulnerability_alerts` per default to `true` for public repositories and
to `false` for private repositories if not explicitly set to avoid drifts
when running `terraform plan`.

## [0.10.0]

### Added
Expand Down Expand Up @@ -262,11 +270,12 @@ Please review plans and report regressions and issues asap so we can improve doc

<!-- markdown-link-check-disable -->

[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.10.0...HEAD
[0.10.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.2...v1.0.0
[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.10.1...HEAD
[0.10.1]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.10.0...v0.10.1

<!-- markdown-link-check-enable -->

[0.10.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.2...v0.10.0
[0.9.2]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.1...v0.9.2
[0.9.1]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.0...v0.9.1
[0.9.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.8.0...v0.9.0
Expand Down
4 changes: 3 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ locals {
gh_labels = local.var_gh_labels == null ? lookup(var.defaults, "issue_labels_merge_with_github_labels", true) : local.var_gh_labels

issue_labels_merge_with_github_labels = local.gh_labels
# Per default, GitHub activates vulnerability alerts for public repositories and disables it for private repositories
vulnerability_alerts = var.vulnerability_alerts != null ? var.vulnerability_alerts : local.private ? false : true
}

locals {
Expand Down Expand Up @@ -106,7 +108,7 @@ resource "github_repository" "repository" {
topics = local.topics

archive_on_destroy = var.archive_on_destroy
vulnerability_alerts = var.vulnerability_alerts
vulnerability_alerts = local.vulnerability_alerts

dynamic "template" {
for_each = local.template
Expand Down

0 comments on commit 0889e6c

Please sign in to comment.