Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix info plist membership #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix info plist membership #6

wants to merge 3 commits into from

Conversation

jsvatek
Copy link

@jsvatek jsvatek commented Apr 21, 2022

Importing UIScaler as a swift package in Kamino is creating a warning:

found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target

The unhandled file is the Info.plist. It's needed for building via the Xcode project file, but not for building as a SM, so I excluded it.

Also - I let Xcode "update the project settings" which:

  1. Updated the minimum iOS version to 12 (which I think is fine on both products)
  2. Enabled whole module compilation
  3. Enabled testability in debug
  4. Enabled a whole bunch of reasonable looking compiler warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlTavares AlTavares AlTavares approved these changes

@MatheusCavalca MatheusCavalca MatheusCavalca approved these changes

@jerelevine jerelevine jerelevine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsvatek @AlTavares @MatheusCavalca @jerelevine