This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Bold / Italic / Strike / Underline buttons don't work correctly #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Problem: `addRange` or `removeAllRanges` kills the browser command states. * Store cache in `commandCache` * Add `updateCommandCache` and `restoreCommandCache` methods * Add support for command-with-arg buttons to be in an active state * Update command cache when running `execCommand` * Store and then update selected commands when selecting a toolbar button * Create the command cache by looking up the buttons that are in the DOM, set the default value to `false`
* Map multiple hotkeys in a string into single hotkey commands * Store them in a hash * When buttons are pressed (`keydown`), compute a string to match them on * They must match this format: * Keys must come in order of modifiers as shown below: * <CTRL>+(<SHIFT>+)<KEY> `(shift optional)` * <META>+(<SHIFT>+)<KEY> * <ALT>+(<SHIFT>+)<KEY> * <SHIFT>+<KEY> * <KEY> `(i.e. tab)` * Change `bindHotKeys` to only bind single events for `keydown` and `keyup` * Re-map the keys into a hash as mentioned above * Prevent propagation and default if we match a command we're allowed * Add callback option to test a hotkey to see if it's allowed. * Add `namsepaceEvents` helper, to create all events with a namespace * Add default callback for `hotKeyEnabledCallback` * returns `true` if a hotkey can execute browser command * takes parameter `command`. i.e. `bold`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addRangeorremoveAllRangeskills the browser command states.commandCacheupdateCommandCacheandrestoreCommandCachemethodsexecCommandbutton
DOM, set the default value to
false