Increase network read timeout when sending transactions #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking into this. I agree that time timeout can be too short, particularly over the famously slow TOR network. However, I'm not sure the answer is to set it as high as 5 minutes by default in case of genuine timeouts. Don't have a definitive answer here. Do you think it would be worth making this a configurable parameter? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes increase the network read timeout from 20 seconds to 5 minutes when sending transactions to avoid timing out too early when exchanging a slate with a device that takes longer than 20 seconds to generate a reply.
This will improve interoperability with wallets that support the Grin dependent Ledger app since that app takes approximately 90 seconds to generate a bulletproof on current Ledger hardware wallets.