Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hebrew translation #412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RealA10N
Copy link

Please note that Hebrew is a right-to-left language. In order for the site to display the language well, something like html { direction: rtl } needs to be added to the HTML file only when the site is loaded in Hebrew.

Copy link
Collaborator

@theRTC204 theRTC204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

We have a standard with the translations that the name Turnip Prophet is treated as a proper name, and thus not localized. Can you please revert all uses of Turnip Prophet to their English version?

In terms of the right-to-left issue you raised, I have no experience with RTL languages on the web. Would this translation work without the HTML attribute you mentioned? If not, we should probably work on an a mechanism for handling that attribute before merging this in.

@RealA10N
Copy link
Author

RealA10N commented Jan 5, 2021

Hello there! Sorry for waiting so long 😅
I've reverted the translations of the "Turnip Prophet" string, as requested.

About the right-to-left issue: it is possible to merge and use the translation without the attribute, but some text (for example, sentences with both English and Hebrew text) will appear a bit messed up.

A really simple mechanism that will manage this attribute is needed indeed. Unfortunately, my knowledge in JS and HTML is very little and I'm afraid I can't do that. I would suggest saving the direction of each translation language somewhere in the locale translation JSON file and then loading it when the language is selected directly to the direction attribute.

The right-to-left issue is not related only to Hebrew. Would you like me to open a new GitHub issue about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants