Add a High Color Contrast option for colorblind users #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some previews of the light mode option:
Here's the dark mode option:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #254, letting folks who are colorblind more easily differentiate chart colors. Some other tweaks were also included to further create contrast.
I was originally going to have it be a theme under the dropdown, but for simplicity's sake I just put it as a checkbox. This allows for automatic theme switching with this option selected. Should any other themes be added, they can easily add a high color contrast option as well.
I could potentially add it in as a dropdown option, but handling the logic for light/dark switching seemed tricky. If you want me to pursue it, though, let me know!