update 三期型、四期型 #172

NullYing · 2020-04-17T17:32:52Z

Would recommend dropping the （四期型） and （三期型） off these translations. Those suggest a numerical order ot the patterns that both does not map to the order the buttons appear on the website, and possibly worse they also don't match up to their in-game pattern number which would likely end up confusing people who are familiar with the extracted game code.

theRTC204

Thanks for making this change!

DevSplash · 2020-04-18T16:24:11Z

locales/zh-CN.json

+    "large-spike": "大幅上涨",
+    "small-spike": "小幅上涨"


Suggested change

"large-spike": "大幅上涨",

"small-spike": "小幅上涨"

"large-spike": "三期型",

"small-spike": "四期型"

In fact, I think it would be better to use 三期型 and 四期型 (Remove 大幅上涨 and 小幅上涨).

无法理解啥是三期型四期型，可以麻烦解释一下？对于普通人来说，跟我一样有疑问的会有更多

无法理解啥是三期型四期型，可以麻烦解释一下？对于普通人来说，跟我一样有疑问的会有更多

简单来说，三期型上涨三次，四期型上涨四次。
#166

那么我觉得可以翻译成这样，而不是简单的三期型和四期型

三期型（上涨三次）
四期型（上涨四次）

不经过解释的话，很多人都不会知道这两词的意思

It maybe better? It's too difficult

大幅上涨三次
小幅上涨四次

三期型（大幅上涨三次）
四期型（小幅上涨四次）

It maybe better? It's too difficult
大幅上涨三次
小幅上涨四次

三期型（大幅上涨三次）
四期型（小幅上涨四次）

It's too many word

Perhaps it would be better to explain the patterns by adding title attribute.
(Or add mouse hover tips in other ways)

I think 大幅上涨三次 and 小幅上涨四次 is enough to explain, and it easier for regular people to understand.

There is an issue open #41 for adding tooltip/hover that explains how the pattern works.

The idea behind the title is to give a simple name that explains that overall result of the pattern, not each phase of that pattern.

For example, "large spike" means the overall result is a big increase in sell price, but doesn't indicate how many periods the increase will last.

locales/zh-TW.json

peter50216 · 2020-04-18T20:27:17Z

There was a discussion about this on discord yesterday, and I think the conclusion was that we can use the "三期型" "四期型" as pattern names since they're somewhat commonly referred pattern names in many Chinese articles about turnips, and rely on #41 to have a proper solution on explaining the pattern meaning clearly.

theRTC204 · 2020-04-18T21:32:07Z

Yes, ideally we would use a term that is common in the native language as a simple title of the pattern, and then when we add the tooltips that better explain the behavior of the patterns we will localize that information as well.

NullYing · 2020-04-19T01:06:55Z

Yes, ideally we would use a term that is common in the native language as a simple title of the pattern, and then when we add the tooltips that better explain the behavior of the patterns we will localize that information as well.

"三期型" "四期型" is’t common in the native language as a simple, He just appeared in an analyzed article only. After all, people have preconceived habits.

mikebryant · 2020-04-25T14:07:48Z

What's the status of this? I don't understand the language or the discussion here, so I'm a bit in the dark :p

peter50216

I still prefer using the shorter and more "common" (in the AC community) term (三期型, 四期型) and have #41 to have a full description on how each pattern actually looks like.

Another nit pick on the PR's translation is that "大幅上漲三次" and "小幅上漲四次" isn't actually describing the pattern clearly since there's only one "large" increase in the large-spike pattern, but the translation makes it looks like there are three large increases.

So my personal preference for this is:

"三期型" / "四期型" with Tooltip descriptions for pattern names #41
"大幅上涨（三期型）" / "小幅上涨（四期型）" (Additional bonus for this is this also align with the Japanese translation)
"大幅上涨" / "小幅上涨"
"三期型" / "四期型" without Tooltip descriptions for pattern names #41
"大幅上漲三次" / "小幅上漲四次"

peter50216 · 2020-04-25T14:18:08Z

locales/zh-CN.json

@@ -77,4 +77,4 @@
    "contributors-text": "哦！别忘记感谢那些至今为止做出过贡献的人。",
    "contributors": "贡献者"
  }
-}
+}


nit: should have new line at end of file.

theRTC204 · 2020-04-25T15:09:10Z

I don't speak the language either, but Google seems to agree with @peter50216 in that it suggests the translation is "soars three times". If that is actually the translation, then it is an incorrect way to describe the pattern.

KKKKaiZhu · 2020-04-26T12:32:23Z

"大幅上涨" / "小幅上涨" makes more sense to me, and I think it will be more intuitive to most people.
Don't think many player (including me!) have a good understanding to "三期型" / "四期型".
"大幅上漲三次" and "小幅上漲四次" are inaccurate because the pattern doesn't actually "soars 3 times" or "rises 4 times".

yuxincs · 2020-04-28T17:20:53Z

Don't think many player (including me!) have a good understanding to "三期型" / "四期型".

I second that. In fact, I believe we should assume the opposite, especially for the new players that just started on AC:NH.

My personal preference is that we should make the name as simple as possible (therefore "大幅上涨" / "小幅上涨"), and let the tooltips do everything else.

remove 三期型、四期型

65d830d

NullYing changed the title ~~dropping 三期型、四期型~~ drop 三期型、四期型 Apr 17, 2020

theRTC204 previously approved these changes Apr 17, 2020

View reviewed changes

DevSplash reviewed Apr 18, 2020

View reviewed changes

locales/zh-TW.json Outdated Show resolved Hide resolved

更新翻译

a0f6ad9

NullYing dismissed theRTC204’s stale review via a0f6ad9 April 18, 2020 16:57

DevSplash previously approved these changes Apr 18, 2020

View reviewed changes

NullYing changed the title ~~drop 三期型、四期型~~ update 三期型、四期型 Apr 18, 2020

update zh.json

7c59514

NullYing dismissed DevSplash’s stale review via 7c59514 April 18, 2020 17:26

peter50216 reviewed Apr 25, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update 三期型、四期型 #172

update 三期型、四期型 #172

NullYing commented Apr 17, 2020

theRTC204 left a comment

DevSplash Apr 18, 2020

NullYing Apr 18, 2020

DevSplash Apr 18, 2020

NullYing Apr 18, 2020

NullYing Apr 18, 2020

DevSplash Apr 18, 2020

NullYing Apr 18, 2020

DevSplash Apr 18, 2020 •

edited

NullYing Apr 18, 2020 •

edited

theRTC204 Apr 18, 2020

peter50216 commented Apr 18, 2020

theRTC204 commented Apr 18, 2020

NullYing commented Apr 19, 2020

mikebryant commented Apr 25, 2020

peter50216 left a comment •

edited

peter50216 Apr 25, 2020

theRTC204 commented Apr 25, 2020 •

edited

KKKKaiZhu commented Apr 26, 2020 •

edited

yuxincs commented Apr 28, 2020 •

edited

update 三期型、四期型 #172

Are you sure you want to change the base?

update 三期型、四期型 #172

Conversation

NullYing commented Apr 17, 2020

theRTC204 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DevSplash Apr 18, 2020 • edited

Choose a reason for hiding this comment

NullYing Apr 18, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peter50216 commented Apr 18, 2020

theRTC204 commented Apr 18, 2020

NullYing commented Apr 19, 2020

mikebryant commented Apr 25, 2020

peter50216 left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theRTC204 commented Apr 25, 2020 • edited

KKKKaiZhu commented Apr 26, 2020 • edited

yuxincs commented Apr 28, 2020 • edited

DevSplash Apr 18, 2020 •

edited

NullYing Apr 18, 2020 •

edited

peter50216 left a comment •

edited

theRTC204 commented Apr 25, 2020 •

edited

KKKKaiZhu commented Apr 26, 2020 •

edited

yuxincs commented Apr 28, 2020 •

edited