Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACNH UI inspired hover effects for buttons and inputs #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cmargroff
Copy link

No description provided.

Copy link
Collaborator

@theRTC204 theRTC204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate what you're doing here, however there are some quirks with this change on mobile devices.

The hover effects on radios don't work at all on mobile devices.

Also, empty inputs play the hover animation the entire time they are active; but don't play any animation if they are active but not empty.

@cmargroff
Copy link
Author

  • I did light mobile testing. Mobile hover effects obviously aren't available. I originally tested having the scrolling background on selected but it was too much on screen at once. I don't think its feasible to implement this animation on mobile.

  • I simply modified their :hover styles, they have a there are :placeholder-shown clauses on the input rules. I didn't want to change original functionality just styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants