Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate color scheme for colorblind users #254

Open
boosterbeetle opened this issue Apr 24, 2020 · 5 comments · May be fixed by #395
Open

Alternate color scheme for colorblind users #254

boosterbeetle opened this issue Apr 24, 2020 · 5 comments · May be fixed by #395
Labels
UI User Interface Issues

Comments

@boosterbeetle
Copy link

Just noticed the new colors to represent good/bad prices but as someone with red/green colorblindness it's pretty difficult to distinguish between the shades of green. Also checked out the dark mode equivalent and the shades of purple? are also difficult to tell. Not a deal breaker by any means but just leaving some feedback in case you want to add support for other schemes in the future. All in all, great work.

@theRTC204 theRTC204 added the UI User Interface Issues label Apr 24, 2020
@theRTC204
Copy link
Collaborator

Great suggestion. There are a handful of things we should do for accessibility.

@davidcorry
Copy link
Contributor

davidcorry commented May 20, 2020

I've made an initial pass at a higher contrast theme, that should (hopefully) work across the different forms of colorblindness. I don't have any colorblindness, though, so I was relying on an app to simulate it for me. Any feedback from folks who this would benefit would be great! (@boosterbeetle)

I haven't made a dark mode, but depending on interest I can see about how to handle the logic for that.

image

image

@boosterbeetle
Copy link
Author

@davidcorry Screenshot looks good! Easier to tell between different sets of values now.

@davidcorry
Copy link
Contributor

Rad! If anything needs adjusting, let me know. I’ll likely come up with a dark mode version in the next day or two and hopefully we can get it in soon.

@boosterbeetle
Copy link
Author

Yeah, not sure if others want to pitch in but for me, I had a hard time distinguishing between the best and second best values in the previous color scheme (shades of green used were very similar). It's solved here though as one of the blue is much darker than the other one. Don't know if that still causes problems with other users though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User Interface Issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants