Fix extension failure issue #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock timer should start counting *after* acquisition reaches quorum, not before. Otherwise extensions fail because lock is deemed to be expired -- prematurely -- due to long intial wait for acquisition quorum.
| @@ -313,6 +312,8 @@ export default class Redlock extends EventEmitter { | |||
| settings | |||
| ); | |||
|
|
|||
| const start = Date.now(); | |||
There was a problem hiding this comment.
You make a very good point here, but I don't think this implementation is safe: the intent is that the expiration on the JS object is either the same or earlier than the one in redis. This change gets the time after it succeeds and calculates an effective expiration that could exceed the actual guarantee.
That said, I completely agree that each new attempt should use a new "start" saved just before making the actual redis calls.
There was a problem hiding this comment.
Makes sense. Happy to close this out in favor of a better solution from your end
This was referenced Mar 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #166
The lock's timer should start counting after the acquisition reaches quorum, not before. Otherwise, the lock is unfairly penalized for long acquisition wait time, and its extensions subsequent fail.