Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DocC naming to BasicCarMaintenance #207

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Set DocC naming to BasicCarMaintenance #207

wants to merge 1 commit into from

Conversation

hanhqvu
Copy link
Contributor

@hanhqvu hanhqvu commented Oct 23, 2023

What it Does

  • Closes DocC Naming #198
  • This PR will set the DocC generated title with CamelCase, BasicCarMaintenance

How I Tested

  • Ran DocC build command in local environment

Notes

  • N/A

Screenshot

image

@mikaelacaron
Copy link
Owner

@hanhqvu can you screenshot where this setting is in Xcode? because I can't tell from only the pbxproj file

@hanhqvu
Copy link
Contributor Author

hanhqvu commented Oct 23, 2023

@mikaelacaron The settings is under Build Settings for the main app target, it is easier to search with the keyword product module name

image

mikaelacaron
mikaelacaron approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that this was quick fix! I'm actually going to mark this as hacktoberfest-accepted and make this as a change to one of the xcconfig files later after Hacktoberfest. I'll leave it for now

@mikaelacaron mikaelacaron added the hacktoberfest-accepted Accepted PR for Hacktoberfest label Oct 24, 2023
@mikaelacaron mikaelacaron mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelacaron mikaelacaron mikaelacaron approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted PR for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DocC Naming
2 participants
@hanhqvu @mikaelacaron