[Android] remove unnecessary external storage permission #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # android/src/main/java/com/mr/flutter/plugin/filepicker/FilePickerDelegate.java # pubspec.yaml
Pluxury
changed the title
|
Great job! Removing unnecessary privacy permissions is definitely user-friendly. @miguelpruivo , could you take a look at this pull request? |
|
@Pluxury before merging, have you tested in older SDKs such as 21? |
miguelpruivo
added
android
Unfortunately, no. There is no way to do this now, but judging by the documentation, there should be no problems |
|
Can this pull request be merged? @miguelpruivo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have removed everything related to the request for access to external storage. Permission is not required for the plugin to work correctly on android.
This was also discussed in #872
I have tested it on several emulators from API 27 to API 33
P.S I'm sorry, I accidentally deleted the previous PR that was here