Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameForm is Useless class type in complete flasky #463

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

NameForm is Useless class type in complete flasky #463

wants to merge 45 commits into from
+3,258 −173

Conversation

Kaiji33
Copy link

@Kaiji33 Kaiji33 commented Mar 24, 2020

NameForm is defined in Chapter 4.2 . And it is useless class type in complete project flasky . Except for the definition here, it's not used anywhere else.

@miguelgrinberg
Chapter 7: Large file structure (7a)
fb13ded
@miguelgrinberg
Chapter 8: Password hashing with Werkzeug (8a)
4de41b0
@miguelgrinberg
Chapter 8: Authentication blueprint (8b)
db681d3
@miguelgrinberg
Chapter 8: Login and logout with Flask-Login (8c)
cfc8be2
@miguelgrinberg
Chapter 8: User registration (8d)
225ae8d
@miguelgrinberg
Chapter 8: Account confirmation (8e)
b345154
@miguelgrinberg
Chapter 8: Password updates (8f)
74eb936
@miguelgrinberg
Chapter 8: Password resets (8g)
4711144
@miguelgrinberg
Chapter 8: Email address changes (8h)
809d39f
@miguelgrinberg
Chapter 9: User roles and permissions (9a)
97e2ef9
@miguelgrinberg
Chapter 10: User profiles (10a)
d578133
@miguelgrinberg
Chapter 10: Profiles editor (10b)
1d203ce
@miguelgrinberg
Chapter 10: User avatars (10c)
168a9e8
@miguelgrinberg
Chapter 10: Caching of user avatar hashes (10d)
20ce2f9
@miguelgrinberg
Chapter 11: Blog posts (11a)
734aa98
@miguelgrinberg
Chapter 11: Blog posts in profile pages (11b)
e00a745
@miguelgrinberg
Chapter 11: Generate fake users and posts (11c)
8d69cb1
@miguelgrinberg
Chapter 11: Blog post pagination (11d)
b05e1a6
@miguelgrinberg
Chapter 11: Rich text blog posts with Flask-PageDown (11e)
2caf5b7
@miguelgrinberg
Chapter 11: Rich text server side handling with Markdown and Bleach (…
99984b8 
…11f)
@miguelgrinberg
Chapter 11: Permanent links to posts (11g)
f338fb0
@miguelgrinberg
Chapter 11: Blog post editor (11h)
ec2d7e3
@miguelgrinberg
Chapter 12: Database representaton of followers (12a)
c22b78b
@miguelgrinberg
Chapter 12: Followers in the application (12b)
44dd094
@miguelgrinberg
Chapter 12: Followed posts with a join (12c)
3ce5aea
@miguelgrinberg
Chapter 12: Show followed blog posts in home page (12d)
4d077c5
@miguelgrinberg
Chapter 12: Self-followers (12e)
156770a
@miguelgrinberg
Chapter 13: Blog post comments (13a)
a6f626f
@miguelgrinberg
Chapter 13: Comment moderation (13b)
4229217
@miguelgrinberg
Chapter 14: API (14a)
f5cecbd
miguelgrinberg and others added 15 commits March 4, 2020 10:38
@miguelgrinberg
Chapter 15: Coverage metrics (15a)
ca278c2
@miguelgrinberg
Chapter 15: Unit tests with the Flask test client (15b)
359a494
@miguelgrinberg
Chapter 15: API testing with the Flask test client (15c)
29d2b9c
@miguelgrinberg
Chapter 15: Unit tests with Selenium (15d)
2289b0e
@miguelgrinberg
Chapter 16: Logging of slow database queries (16a)
ebbff88
@miguelgrinberg
Chapter 16: Source code profiling (16b)
e114c34
@miguelgrinberg
Chapter 17: Deploy command (17a)
c9d605a
@miguelgrinberg
Chapter 17: Email notification of application errors (17b)
b285ab8
@miguelgrinberg
Chapter 17: Heroku support with Waitress (17c-waitress)
ac67993
@miguelgrinberg
Chapter 17: Heroku support with Gunicorn (17c)
7eba28f
@miguelgrinberg
Chapter 17: Docker support (17d)
c097596
@miguelgrinberg
Chapter 17: MySQL support for Docker (17e)
3fb6dc1
@miguelgrinberg
Chapter 17: Docker Compose support (17f)
5c285fb
@miguelgrinberg
Chapter 17: Traditional hosting (17g)
6ff384a
@Kaiji33
Update forms.py
b0b2de4 
NameForm is Useless class type
@miguelgrinberg
Copy link
Owner

The NameForm class is used in the early part of the book, more specifically in chapter 4. You are correct that eventually this form isn't used anymore and can be removed.

@miguelgrinberg miguelgrinberg self-assigned this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miguelgrinberg miguelgrinberg

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet