Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round 18 projections #275

Merged
merged 5 commits into from
May 8, 2024
Merged

Round 18 projections #275

merged 5 commits into from
May 8, 2024

Conversation

mooresea
Copy link
Contributor

@mooresea mooresea commented May 7, 2024

Description

Please include a brief description of your change.


If this section does not apply to you, please delete it in your PR

If this is a new team submission, please include the following details :-

  • Team name:
  • Model Name:
  • Institution:

If this section does not apply to you, please delete it in your PR

If you are adding new scenarios to an existing model, please include the following details:-

  • Team name:
  • Model name that is being updated:

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Copy link

github-actions bot commented May 7, 2024

❌ Error 004: The round id (date in the submission file) is not associated with any task_ids round. Please verify the date information in 'path' or in the 'round_id' parameter.

Copy link

github-actions bot commented May 7, 2024

Error in compute.Dataset(x) :
Invalid: Float value 0.01 was truncated converting to int64

Fixed output_type_id and run_grouping columns for quantile and sample types
Copy link

github-actions bot commented May 7, 2024

Run validation on files: 2024-04-28-NotreDame-FRED.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

No errors or warnings found in target and associated columns

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

❌ Error 802: The age_group column is missing at least 1 required value: '65-130', '0-64'. 'age_group' should contain: 0-130, 65-130, 0-64, for the target: inc death, inc hosp.
❌ Error 802: The age_group column is missing at least 1 required value: '65-130', '0-64'. 'age_group' should contain: 0-130, 65-130, 0-64, for the target: inc death, inc hosp, cum death, cum hosp.

@mooresea
Copy link
Contributor Author

mooresea commented May 7, 2024

I didn't realize that age groups were required this round. Adding these would require rerunning all of our projections, so will probably take a couple of extra weeks.

@LucieContamin
Copy link
Collaborator

Hi @mooresea,

Thanks for the submission. The three age groups are required indeed, so the validation will return an error if they are missing. However, I can ignore that error and we will accept a submission with only the overall population.

Also, just to be sure I understand correctly the "grouping" information in the submission: each model runs has different run_grouping (model run independent) for every stochastic_run, grouped by age group, horizon, location, scenario_id, target, like the example 2 in the Sample documentation page (https://scenariomodelinghub.org/documentation/sample_format.html) but with additional grouping. Is that correct?

Please feel free to let me know if any issues or questions,
Best, Lucie

@mooresea
Copy link
Contributor Author

mooresea commented May 7, 2024 via email

@LucieContamin
Copy link
Collaborator

Hi again,

Thanks for the quick reply. Just to verify for the "grouped" by information in the submission, I have the target included, meaning the projection are grouped by age group, horizon, location, scenario_id, target . Is that correct?
For example, in the submission file: the trajectory with run_grouping 1 and the stochastic_run 1 contains all the age groups, horizons, locations, scenarios and targets.
If the projections are not grouped by target, shouldn't we have the 2 targets in different trajectory ID? does that make sense?

Please feel free to let me know if any issues or questions,
Best, Lucie

@mooresea
Copy link
Contributor Author

mooresea commented May 7, 2024 via email

@LucieContamin
Copy link
Collaborator

Thank you for the confirmation,
Best, Lucie

@LucieContamin LucieContamin merged commit 7b101cc into midas-network:master May 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants