Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNC Charlotte Round 18 submission with age information #274

Merged
merged 6 commits into from
May 7, 2024

Conversation

lunarmouse
Copy link
Contributor

Description

Please include a brief description of your change.


If this section does not apply to you, please delete it in your PR

If this is a new team submission, please include the following details :-

  • Team name:
  • Model Name:
  • Institution:

If this section does not apply to you, please delete it in your PR

If you are adding new scenarios to an existing model, please include the following details:-

  • Team name: UNC Charlotte (formerly UNCC)
  • Model name that is being updated: Hierbin

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Delete intermediate results. Will be replaced by final age-specific results.
New results with age information (0-65, 65-130, 0-130). However, the age-specific estimates are from post-processing of the overall data.
@lunarmouse
Copy link
Contributor Author

Hi @LucieContamin Lucie, received an error message but not sure what caused the error... Could you please take a look and let me know what could have gone wrong? Thanks very much, SC

@LucieContamin
Copy link
Collaborator

Hi @lunarmouse , Thank you for the update. It seems to be on the GitHub Action side, I will look into it.
In the meantime, I ran the validation manually and here is the results of the validation:

Run validation on files: 2024-04-28-UNCC-hierbin.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

❌ Error 510: Each group combination should have one unique value. 9734400 unique groups have been identified with this issue. For example:
group: 2024-04-28, A-2024-03-01, 01, inc hosp, 1, 0-130, sample, 1;
group: 2024-04-28, A-2024-03-01, 01, inc hosp, 2, 0-130, sample, 1;
group: 2024-04-28, A-2024-03-01, 01, inc hosp, 3, 0-130, sample, 1;
etc.

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

❌ Error 802: The age_group column contains unexpected value: '0-65'. 'age_group' can only be: 0-130, 65-130, 0-64, for the target: inc death, inc hosp.
❌ Error 802: The age_group column is missing at least 1 required value: '0-64'. 'age_group' should contain: 0-130, 65-130, 0-64, for the target: inc death, inc hosp.

@lunarmouse
Copy link
Contributor Author

Hi @LucieContamin Lucie thanks for the feedback. Will fix these issues soon.

Fixed age group naming issue and unique value issue.
Copy link

github-actions bot commented May 7, 2024

Run validation on files: 2024-04-28-UNCC-hierbin.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

1 similar comment
Copy link

github-actions bot commented May 7, 2024

Run validation on files: 2024-04-28-UNCC-hierbin.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

Copy link

github-actions bot commented May 7, 2024

No projection submission file in the standard SMH file format found in the Pull-Request. No validation was run.

Copy link

github-actions bot commented May 7, 2024

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@LucieContamin
Copy link
Collaborator

Hi @lunarmouse ,

Can I ask why did you delete your submission file? Did you wish to be removed from the R18?

Thanks,
Lucie

@lunarmouse
Copy link
Contributor Author

Hi Lucie @LucieContamin I found some issues in death projections and will upload a new one soon. Thanks!

Fixed some issues in death projection
Copy link

github-actions bot commented May 7, 2024

Run validation on files: 2024-04-28-UNCC-hierbin.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@lunarmouse
Copy link
Contributor Author

Oh Lucie @LucieContamin I just realized that I directly deleted the file on the midas repo instead of my own repo via pull request.... Sorry about that from a lunar mouse at 3am!

@LucieContamin
Copy link
Collaborator

Oh Lucie @LucieContamin I just realized that I directly deleted the file on the midas repo instead of my own repo via pull request.... Sorry about that from a lunar mouse at 3am!

It's not a problem at all it was in your PR so on your forked repo. I was just wondering if I was missing some information.

@LucieContamin
Copy link
Collaborator

Please let me know when you have your final version, so I can merge it. Thanks!

@lunarmouse
Copy link
Contributor Author

Hi Lucie @LucieContamin the most recent PR around 3:45 should be the final version. Hopefully no more bugs. Thanks! SC

@LucieContamin
Copy link
Collaborator

Perfect! Thanks for the update! I will merge it soon!
Best, Lucie

@LucieContamin LucieContamin merged commit 443d391 into midas-network:master May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants