Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round 18 UNC Charlotte Hierbin #271

Merged
merged 7 commits into from
May 3, 2024

Conversation

lunarmouse
Copy link
Contributor

Hospitalization projections only. Still tweaking on death.

Description

Please include a brief description of your change.


If this section does not apply to you, please delete it in your PR

If this is a new team submission, please include the following details :-

  • Team name:
  • Model Name:
  • Institution:

If this section does not apply to you, please delete it in your PR

If you are adding new scenarios to an existing model, please include the following details:-

  • Team name: UNC Charlotte (UNCC)
  • Model name that is being updated: Hierbin

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Hospitalization projections only. Still tweaking on death.
Copy link

❌ Error 004: The round id (date in the submission file) is not associated with any task_ids round. Please verify the date information in 'path' or in the 'round_id' parameter.

@LucieContamin
Copy link
Collaborator

Hi @lunarmouse ,

Thank you for your submission. The validation did not run completely because the date in the filename and the origin_date column should correspond to: "The date YYYY-MM-DD should correspond to the start date for scenarios projection ("first date of simulated transmission/outcomes" as noted in the scenario description on the main README, Submission Information)." So, here it will be "2024-04-28".

Please let me know if any other issues or questions,

Best, Lucie

Copy link

Run validation on files: 2024-04-28-UNCC-hierbin.gz.parquet
❌ Error 101: At least one column name is misspelled or does not correspond to the expected column names

@LucieContamin
Copy link
Collaborator

Just to add more information on the last validation run. The submission format has changed, please refer to the Model Results File Format section in the associated README.

Please feel free to let me know if any issues or questions,

Best, Lucie

@lunarmouse
Copy link
Contributor Author

Thanks Lucie, just want to confirm, is age group required (<65 and >65 and all) for this round #18?

@LucieContamin
Copy link
Collaborator

The three age groups are required, so the validation will return an error if they are missing. However, I can ignore that error and we will accept a submission with only the overall population.

Please feel free to let me know if any issues or questions,
Best, Lucie

Copy link

github-actions bot commented May 1, 2024

Run validation on files: 2024-04-28-UNCC-hierbin.gz.parquet
❌ Error 101: At least one column name is misspelled or does not correspond to the expected column names

Copy link

github-actions bot commented May 1, 2024

Run validation on files: 2024-04-28-UNCC-hierbin.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

❌ Error 802: The age_group column is missing at least 1 required value: '65-130', '0-64'. 'age_group' should contain: 0-130, 65-130, 0-64, for the target: inc death, inc hosp.

@lunarmouse
Copy link
Contributor Author

Hi Lucie, could you please accept this pull request as I plan to provide age group specific projections by the weekend. This submission has overall age (0-130) to validate the results. Please let me know if I need to pull again. Thanks! SC

@LucieContamin
Copy link
Collaborator

HIi @lunarmouse ,

Thank you for the update, I just wanted to verify that I understand the pairing information in the sample correctly. According to your submission, each model run has different run_grouping (model run independent) for every stochastic run, grouped by age_group, horizon, scenario, location, target, am I correct?

Thanks,
Lucie

@lunarmouse
Copy link
Contributor Author

Hi Lucie, yes the grouping is grouped by horizon, scenario, location, and target. When I further process age-specific projections, age_group will also be part of the group as well. Thanks for checking in! SC

@LucieContamin LucieContamin merged commit 833c860 into midas-network:master May 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants