Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVA-EpiHiper submission to round 17 #258

Merged
merged 2 commits into from May 26, 2023
Merged

Conversation

chenj-uva
Copy link
Contributor

Description

50 trajectories of hospitalizations for 17 states.

@github-actions
Copy link

[1] "Run validation on file: 2023-04-16-UVA-EpiHiper.gz.parquet"

@LucieContamin
Copy link
Collaborator

Hi @chenj-uva ,

Thanks for the submission, it seems that the validation had issues, I apologize for the inconvenience and will fix that. In the meantime, I run the validation locally and please find here the result:

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

❌ Error 5040: For the type 'sample', the type_id should correspond to: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100 at least one id is incorrect, please verify

Target Columns:

❌ Error 602: The data frame does not contain projections for 'inc death' target(s).

Locations:

No errors or warnings found on Location

Sample:

🟡 Warning 901: The column 'sample' should contains integer values between 1 and 100 (included), please verify.
🟡 Warning 901: The column 'sample' contains less unique sample ID then expected. Up to 100 unique 'samples' for each scenario/target/location(/age_group) can be submitted.
❌ Error 903: The column 'sample' should contains integer values only. Please verify

Quantiles:

No errors or warnings found on quantiles values and format

As I understand, this submission does not contain "inc death" value and include less than 100 samples, if it's expected I will ignore the error 602 and the warning 901.
Please feel free to let me know if any issues or questions,

Best,
Lucie

@chenj-uva
Copy link
Contributor Author

Hi @LucieContamin ,

Yes we have submitted only 50 samples (trajectories) and only hospitalizations (so no 'inc death' projections). Thanks.

Best,
Jiangzhuo Chen

@LucieContamin
Copy link
Collaborator

Hi @chenj-uva ,

Thanks for the response. However, would it be possible to fix the other errors, please?

❌ Error 5040: For the type 'sample', the type_id should correspond to: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100 at least one id is incorrect, please verify

❌ Error 903: The column 'sample' should contains integer values only. Please verify

Please feel free to let me know if any issues or questions,
Best,
Lucie

@LucieContamin
Copy link
Collaborator

Hi @chenj-uva ,

Sorry for the multiple message, could I also ask if you plan to submit other target (death) and other location?

Thanks,
Lucie

@chenj-uva
Copy link
Contributor Author

Hi @LucieContamin ,

I have updated our submission file. It is being validated now. At this time we are submitting only these locations and only hospitalizations. We do plan to continue work on other locations and once the projections for them become ready we will update our submission. But that will take a few more days. Thanks.

Best,
Jiangzhuo Chen

@github-actions
Copy link

[1] "Run validation on file: 2023-04-16-UVA-EpiHiper.gz.parquet"

@LucieContamin
Copy link
Collaborator

Hi @chenj-uva ,

Thanks for the update, here the output of the validation:
[1] "Run validation on file: 2023-04-16-UVA-EpiHiper.gz.parquet"

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

❌ Error 602: The data frame does not contain projections for 'inc death' target(s).

Locations:

No errors or warnings found on Location

Sample:

🟡 Warning 901: The column 'sample' should contains integer values between 1 and 100 (included), please verify.

Quantiles:

No errors or warnings found on quantiles values and format

I will ignore error 602.
The warning 901 seems to be because your column is "character" instead of "numeric". I can ignore it for now, but would it be possible to fix it in the next update, please?

Please let me know if any questions or issues.
Best,

Lucie

@chenj-uva
Copy link
Contributor Author

There is no 'sample' column. Is it 'type_id' column?

@LucieContamin
Copy link
Collaborator

Yes that is correct, sorry for the confusion. It's the type-Id column associated with the samples

@chenj-uva
Copy link
Contributor Author

'type_id' column should be character, no? R won't take integer and float in the same column (integer will be converted to float).

@LucieContamin
Copy link
Collaborator

Currently, the column type_id should be numeric. They are converted to "float", but the validation is testing the range of the type_id column, that's why the warning 901 appears. It tested that the samples ID are integer between 1 and 100 and it cannot be tested on character value.

@chenj-uva
Copy link
Contributor Author

OK I can make type_id as numeric. Do I need to make the change to the current submission file (which will trigger the validation process again) or do I just need to do this for the future updated submission? I am not sure whether it matters for our submission file to be included in the ensemble.

@LucieContamin
Copy link
Collaborator

Thanks, It should be good for this first version, but it will be good to do it for the future updated submission. It will not impact the inclusion of your submission in the ensemble

@LucieContamin LucieContamin merged commit f2963dd into midas-network:master May 26, 2023
1 check passed
@chenj-uva
Copy link
Contributor Author

Hi @LucieContamin ,

I am about to submit projections of a few more states (last time we submitted 17 states). Do you think I should combine the new data with what's in the existing file and submit an updated version of the file, or just submit new data in a separate file? Thanks.

@harryhoch
Copy link
Contributor

@chenj-uva , @LucieContamin is out on vacation this week. Can you wait until Monday?

@chenj-uva
Copy link
Contributor Author

@harryhoch Thank you for the response! I have asked Cecile too and will submit a file of both old and new data combined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants