Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed horizon and type id column name mismatch #255

Merged
merged 5 commits into from May 19, 2023

Conversation

lunarmouse
Copy link
Contributor

Description

Please include a brief description of your change.


If this section does not apply to you, please delete it in your PR

If this is a new team submission, please include the following details :-

  • Team name:
  • Model Name:
  • Institution:

If this section does not apply to you, please delete it in your PR

If you are adding new scenarios to an existing model, please include the following details:-

  • Team name: uncc
  • Model name that is being updated: hierbin

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

@github-actions
Copy link

[1] "Run validation on file: 2023-04-16-UNCC-hierbin.gz.parquet"
[1] "End of validation check: all the validation checks were successful"

@LucieContamin
Copy link
Collaborator

Hi @lunarmouse,

Thank you for the update, the submission file looks to all good.
I noticed after merging your last PR that there is some issues with the abstract. Would it be possible to update the abstract for the round 17 in this PR, please?
The file should be named: "2023-04-16-UNCC-hierbin-Abstract.md" and the content of the abstract should match the 2023-04-16-MyTeam-MyModel-Abstract.md (https://github.com/midas-network/covid19-scenario-modeling-hub/blob/master/data-processed/MyTeam-MyModel/2023-04-16-MyTeam-MyModel-Abstract.md )

Please let me know if any issues or questions,
Thanks,
Lucie

@lunarmouse
Copy link
Contributor Author

Hi Lucie, thanks for the heads up. I updated the abstract based the current template. Have a nice day! Shi

@github-actions
Copy link

[1] "Run validation on file: 2023-04-16-UNCC-hierbin.gz.parquet"
[1] "End of validation check: all the validation checks were successful"

@LucieContamin
Copy link
Collaborator

Hi Shi,

Thank you for the update!
However, just a minor fix, would it be possible to remove the subsections in:
Initial distribution of susceptibility (if available), please? (meaning removing the "Proportion of people that were infected with Omicron", "Proportion of people that are naïve at start of projection (not vaccinated or infected)" and "other" subtitle, it should only be free text).

Also, the filename seems to still miss the model name, could you please update it to "2023-04-16-UNCC-hierbin-Abstract.md"?

Many thanks,
Lucie

@github-actions
Copy link

[1] "Run validation on file: 2023-04-16-UNCC-hierbin.gz.parquet"
[1] "End of validation check: all the validation checks were successful"

@lunarmouse
Copy link
Contributor Author

Hi Lucie, I just fixed these issues and submitted a PR. Thanks! SC

@LucieContamin
Copy link
Collaborator

Thank you very much, it looks all good. I will merge the PR.
Best, Lucie

@LucieContamin LucieContamin merged commit 8276070 into midas-network:master May 19, 2023
1 check passed
@github-actions
Copy link

[1] "Run validation on file: 2023-04-16-UNCC-hierbin.gz.parquet"
[1] "End of validation check: all the validation checks were successful"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants