Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/query response #25

Merged
merged 17 commits into from Mar 7, 2019
Merged

Feat/query response #25

merged 17 commits into from Mar 7, 2019

Conversation

jobala
Copy link
Contributor

@jobala jobala commented Mar 4, 2019

Overview

  1. Adds a QueryResponse Component
  2. Integrates Monaco Editor
  3. Eject Create React App, leading to the automatic addition of files in the config and scripts folders

Demo

image

image

Notes

We had to eject Create React App so that we can access the webpack config file.
Making the editor read only prevents formatting of the json content.

This pull request doesn't add any React Component tests. This is because of the transient failure of the jest runtime when transforming editor.api.js. The fixes suggested here works for some cases and fails on others. They did not work for our use case.

Testing Instructions

  • Pull changes
  • Run a query
  • Observe the response body being populated with formatted json content.

Fixes

#9
#8
#2

@jobala jobala marked this pull request as ready for review March 6, 2019 03:00
@thewahome-zz thewahome-zz merged commit 80b4da1 into dev Mar 7, 2019
@jobala jobala deleted the feat/query-response branch March 11, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants