Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong version Microsoft.Office 16.0.17531.20046 #150777

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

treysis
Copy link
Contributor

@treysis treysis commented Apr 24, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@treysis
Copy link
Contributor Author

treysis commented Apr 24, 2024

Follow up of #150300
Fixes #149361

@treysis
Copy link
Contributor Author

treysis commented Apr 24, 2024

@stephengillie how to get rid of this "Validation-Dependency-Removal" warning/label? How can the other package put a block on this package? Simply because downgrading is not supposed to happen in winget repo?

@stephengillie
Copy link
Collaborator

URL: https://officecdn.microsoft.com/pr/wsus/setup.exe
Status Code: 200

(Automated message - build 877)

@treysis
Copy link
Contributor Author

treysis commented Apr 24, 2024

@stephengillie This PR removes this version folder incl. the manifests because this is not the version of Office, but just the version of the installer file (i.e. deployment tool).

@treysis
Copy link
Contributor Author

treysis commented Apr 24, 2024

@stephengillie This version of Office (16.0.17531.20046) doesn't exist and needs to be removed entirely. The whole manifest is wrong. The newest version of Office is 16.0.17425.20176. Check the official release history: https://learn.microsoft.com/en-us/officeupdates/update-history-microsoft365-apps-by-date
Version 17531.20046 is just the latest version of setup.exe, the deployment tool. It doesn't have anything to do with the latest version of Office.

@stephengillie
Copy link
Collaborator

URL: https://officecdn.microsoft.com/pr/wsus/setup.exe
Status Code: 200

(Automated message - build 877)

@stephengillie stephengillie merged commit d4f0e6c into microsoft:master Apr 25, 2024
3 of 5 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 25, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Dependency-Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants