Fix #20768: Don't seed search without selection #80477
Conversation
|
|
This makes CMD/CTRL+F consistent with other editors/IDEs.
wkornewald
force-pushed
the
no-seed-search-without-selection
branch
from
b5953a5
to
33cd8a0
Compare
|
Hello, could you please give any estimates when this pull request could be merged? It's been more then 2 years that people have issues with this unexpected behaviour and thanks to @wkornewald it's been fixed but seems nobody is interested in accepting changes made by pro-active community members. |
|
This has been sat idle for nearly six months now - can someone with the relevant permissions confirm why this is problematic or merge it? |
|
Is there any timeline for this being merged? This would be an incredible UX improvement and I do not want to disable |
|
hello vs code wakeup and merge this. your stupid ctrl f behavior is so annoying |
|
@rebornix Is there a timeline on this? Can you please let people know. |
rebornix
added
feature-request
|
Oct, Nov, Dec ... |
|
When will these changes appear in vs code? |
|
Apparently already fixed. |
Fixes #20768. This makes CMD/CTRL+F consistent with other editors/IDEs (actually, almost all software on all platforms).
Without any text selected, the current behavior (with
seedSearchStringFromSelectionenabled) is to search for whatever word is under the cursor. This is unexpected because all (>99%) other software simply keeps the search field unchanged, so you can continue searching. Try it in some JetBrains IDE, Eclipse, NetBeans, Sublime, Notepad++, Firefox or Chrome in an input field, MS Word, or any other popular software. Nobody does that except for VS Code, so it breaks common user expectations and makes a very common use-case annoying (i.e. continuing from the last search).That's why I have fully removed the old behavior. If you want to search for the word under the cursor you can simply select it before pressing CMD/CTRL+F like in almost every other application.