Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening extension from extension pack tab #73350

Merged
merged 1 commit into from May 6, 2019
Merged

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented May 6, 2019

fix #73215

Fix is to pass IExtension instead of IExtensionData to open.

In addition, restricted opening the extension only when selected through keyboard and removed opening to the side. It was like this before adopting to new tree and is changed after wrongly.

Note: Opening through mouse is handled separately using a link on the label

@sandy081 sandy081 added this to the April 2019 milestone May 6, 2019
@sandy081 sandy081 requested a review from joaomoreno May 6, 2019 13:25
@sandy081 sandy081 self-assigned this May 6, 2019
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sandy081 sandy081 merged commit 171a990 into master May 6, 2019
@joaomoreno joaomoreno deleted the sandy081/fix73215 branch May 6, 2019 14:52
@jrieken jrieken added the verified Verification succeeded label May 8, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verified Verification succeeded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error closing extensions editor
3 participants