Initial implementation of quick-fix support for typescript #7261
Conversation
kisstkondoros
force-pushed
the
quickfix
branch
3 times, most recently
from
053ec51
to
5b24ae6
Compare
|
I just created a feature request for one of these the other day #7073 |
Code is heavily based on Atom-TypeScript's quick fix implementation https://github.com/TypeStrong/atom-typescript/tree/master/lib/main/lang
|
👍 for a way to get imports resolved via quick fix. |
|
@kisstkondoros thanks for the pull request. Although I like the features provided they don't fit architecturally how VS Code integrated with TypeScript. All TS smartness in VS Code is running in a separate process (the tsserver) maintained in this git repository (https://github.com/Microsoft/TypeScript). Your pull request basically creates another compiler instance in the extension host, builds AST and resolves symbols. This doubles the memory consumption and in the worst case makes the extension host unresponsive which might impact other extensions. That is why all language smartness (even linters like eslint, tslint, ...) are run in a language server in its own process. The best way to integrate quick fix into VS Code is to integrate it into the tsserver directly. VS Code basically consumes the tsserver as a binary. We don't own it and changes to the tsserver can't occur in the VS Code git repository. Unless I don't miss anything I need to reject the PR and ask you to create a corresponding PR against the https://github.com/Microsoft/TypeScript repository. |
|
@dbaeumer I thought this might be a temporary solution until microsoft/TypeScript#6943 is resolved. It is on the roadmap for TS 2.1 https://github.com/Microsoft/TypeScript/wiki/Roadmap#20 I'm a bit sad, but I understand the reasons behind. |
|
@kisstkondoros we should not wait until TS 2.1. I would like to encourage you to work on a PR against the TS server. I do the same if I need features in there and I volunteer to get you started if you want. However the final answer if the PR gets accepted depends on the TS team. So why don't you ask in microsoft/TypeScript#6943 if they would accept a PR? |
|
@dbaeumer I'll certainly check what can I do in TS core with the topic (after work) 😄 |
|
@dbaeumer finally I've reached a state which can push this forward (I hope) and published it in the mentioned post. Thank you for the motivation! |
|
@kisstkondoros great to hear that you are still working on this! |
|
TypeScript team has finished it in TS2.1 right now , anything update ? |
|
We started to look into adapting TS 2.1 for VS Code 1.8 |
Code is heavily based on Atom-TypeScript's quick fix implementation
https://github.com/TypeStrong/atom-typescript/tree/master/lib/main/lang
It still needs a lot of work ...
